FluxEngine/testing: Difference between revisions
Jump to navigation
Jump to search
(add another image) |
(add another image) |
||
| Line 169: | Line 169: | ||
writing 77 tracks, 1 heads, 8 sectors, 1024 bytes per sector, 616 kB total | writing 77 tracks, 1 heads, 8 sectors, 1024 bytes per sector, 616 kB total | ||
</pre> | </pre> | ||
image created: [[File:525-nd-f17b-210628f01-xx-01d 5 r5.img.bz2|525-nd-f17b-210628f01-xx-01d 5 r5.img.bz2]] | |||
got even one more sector. | got even one more sector. | ||
<pre> | <pre> | ||
Revision as of 15:44, 16 February 2020
Back to FluxEngine page. Document FluxEngine testing.
- 2020-02-16
- try using FE (FluxEngine) to read a ND format 17b floppy which has read errors. First the normal way
tingo@z30b:~/personal/projects/psoc/fluxengine/tmp$ ../fluxengine read ibm -s:d=1:s=0:t=0-76 --retries=0 -o 525-nd-f17-210628f01-xx-01d.img Reading from: :d=1:s=0:t=0-76 Measuring rotational speed... 166ms [..] Autodetecting output geometry H.SS Tracks ---> 0. 0 .................................................................BBB......... 0. 1 ..............................................................B.............. 0. 2 ............................................................................. 0. 3 ............................................................................. 0. 4 ...............................................................XBBBB......... 0. 5 ......................................................................B...... 0. 6 ...............................................................BB.....BBBB... 0. 7 ............................................................................. Good sectors: 600/616 (97%) Missing sectors: 1/616 (0%) Bad sectors: 15/616 (2%) writing 77 tracks, 1 heads, 8 sectors, 1024 bytes per sector, 616 kB total
image created File:525-nd-f17b-210628f01-xx-01d.img.bz2
try with --revolutions=2
tingo@z30b:~/personal/projects/psoc/fluxengine/tmp$ ../fluxengine read ibm -s:d=1:s=0:t=0-76 --retries=0 --revolutions=2 -o 525-nd-f17-210628f01-xx-01d_2.img Reading from: :d=1:s=0:t=0-76 Measuring rotational speed... 166ms [..] Autodetecting output geometry H.SS Tracks ---> 0. 0 .................................................................BBB......... 0. 1 ..............................................................B.............. 0. 2 ............................................................................. 0. 3 ............................................................................. 0. 4 ................................................................BBBB......... 0. 5 ......................................................................B...... 0. 6 ...............................................................BB.....BBBB... 0. 7 ............................................................................. Good sectors: 601/616 (97%) Missing sectors: 0/616 (0%) Bad sectors: 15/616 (2%) writing 77 tracks, 1 heads, 8 sectors, 1024 bytes per sector, 616 kB total
image created File:525-nd-f17b-210628f01-xx-01d 2.img.bz2
does --revolutions=3 help?
tingo@z30b:~/personal/projects/psoc/fluxengine/tmp$ ../fluxengine read ibm -s:d=1:s=0:t=0-76 --retries=0 --revolutions=3 -o 525-nd-f17b-210628f01-xx-01d_3.img Reading from: :d=1:s=0:t=0-76 [..] Autodetecting output geometry H.SS Tracks ---> 0. 0 .................................................................BBB......... 0. 1 ..............................................................B.............. 0. 2 ............................................................................. 0. 3 ............................................................................. 0. 4 ................................................................BBBB......... 0. 5 ......................................................................B...... 0. 6 ......................................................................BBBB... 0. 7 ............................................................................. Good sectors: 603/616 (97%) Missing sectors: 0/616 (0%) Bad sectors: 13/616 (2%) writing 77 tracks, 1 heads, 8 sectors, 1024 bytes per sector, 616 kB total
image created File:525-nd-f17b-210628f01-xx-01d 3.img.bz2
--revolutions=4 then
tingo@z30b:~/personal/projects/psoc/fluxengine/tmp$ ../fluxengine read ibm -s:d=1:s=0:t=0-76 --retries=0 --revolutions=4 -o 525-nd-f17b-210628f01-xx-01d_4.img [..] H.SS Tracks ---> 0. 0 .................................................................BBB......... 0. 1 ............................................................................. 0. 2 ............................................................................. 0. 3 ............................................................................. 0. 4 ................................................................BBBB......... 0. 5 ......................................................................B...... 0. 6 ......................................................................BBBB... 0. 7 ............................................................................. Good sectors: 604/616 (98%) Missing sectors: 0/616 (0%) Bad sectors: 12/616 (1%) writing 77 tracks, 1 heads, 8 sectors, 1024 bytes per sector, 616 kB total
image created: File:525-nd-f17b-210628f01-xx-01d 4.img.bz2
--revolutions=5
tingo@z30b:~/personal/projects/psoc/fluxengine/tmp$ ../fluxengine read ibm -s:d=1:s=0:t=0-76 --retries=0 --revolutions=5 -o 525-nd-f17b-210628f01-xx-01d_5.img [..] H.SS Tracks ---> 0. 0 ............................................................................. 0. 1 ............................................................................. 0. 2 ............................................................................. 0. 3 ............................................................................. 0. 4 ................................................................BBBB......... 0. 5 ......................................................................B...... 0. 6 ......................................................................BBBB... 0. 7 ............................................................................. Good sectors: 607/616 (98%) Missing sectors: 0/616 (0%) Bad sectors: 9/616 (1%) writing 77 tracks, 1 heads, 8 sectors, 1024 bytes per sector, 616 kB total
image created: File:525-nd-f17b-210628f01-xx-01d 5.img.bz2
try with --revolutions=10 then (even if it is going to be slow)
tingo@z30b:~/personal/projects/psoc/fluxengine/tmp$ ../fluxengine read ibm -s:d=1:s=0:t=0-76 --retries=0 --revolutions=10 -o 525-nd-f17b-210628f01-xx-01d_10.img [..] H.SS Tracks ---> 0. 0 ............................................................................. 0. 1 ............................................................................. 0. 2 ............................................................................. 0. 3 ............................................................................. 0. 4 .................................................................BB.......... 0. 5 ............................................................................. 0. 6 ......................................................................BBBB... 0. 7 ............................................................................. Good sectors: 610/616 (99%) Missing sectors: 0/616 (0%) Bad sectors: 6/616 (0%) writing 77 tracks, 1 heads, 8 sectors, 1024 bytes per sector, 616 kB total
image created: File:525-nd-f17b-210628f01-xx-01d 10.img.bz2
try --revolutions=2 and --retries=5
tingo@z30b:~/personal/projects/psoc/fluxengine/tmp$ ../fluxengine read ibm -s:d=1:s=0:t=0-76 --retries=5 --revolutions=2 -o 525-nd-f17-210628f01-xx-01d_2_r5.img [..] Autodetecting output geometry H.SS Tracks ---> 0. 0 ............................................................................. 0. 1 ............................................................................. 0. 2 ............................................................................. 0. 3 ............................................................................. 0. 4 .................................................................BB.......... 0. 5 ............................................................................. 0. 6 ......................................................................BBBB... 0. 7 ............................................................................. Good sectors: 610/616 (99%) Missing sectors: 0/616 (0%) Bad sectors: 6/616 (0%) writing 77 tracks, 1 heads, 8 sectors, 1024 bytes per sector, 616 kB total
image created: File:525-nd-f17b-210628f01-xx-01d 2 r5.img.bz2
same as --revolutions=10 but quicker. now --revolutions=5 and --retries=5
tingo@z30b:~/personal/projects/psoc/fluxengine/tmp$ ../fluxengine read ibm -s:d=1:s=0:t=0-76 --retries=5 --revolutions=5 -o 525-nd-f17b-210628f01-xx-01d_5_r5.img [..] H.SS Tracks ---> 0. 0 ............................................................................. 0. 1 ............................................................................. 0. 2 ............................................................................. 0. 3 ............................................................................. 0. 4 ..................................................................B.......... 0. 5 ............................................................................. 0. 6 ......................................................................BBBB... 0. 7 ............................................................................. Good sectors: 611/616 (99%) Missing sectors: 0/616 (0%) Bad sectors: 5/616 (0%) writing 77 tracks, 1 heads, 8 sectors, 1024 bytes per sector, 616 kB total
image created: File:525-nd-f17b-210628f01-xx-01d 5 r5.img.bz2
got even one more sector.
tingo@z30b:~/personal/projects/psoc/fluxengine/tmp$ ../fluxengine read ibm -s:d=1:s=0:t=0-76 --retries=5 --revolutions=10 -o 525-nd-f17b-210628f01-xx-01d_10_r5.img [..] H.SS Tracks ---> 0. 0 ............................................................................. 0. 1 ............................................................................. 0. 2 ............................................................................. 0. 3 ............................................................................. 0. 4 .................................................................BB.......... 0. 5 ............................................................................. 0. 6 ......................................................................BBBB... 0. 7 ............................................................................. Good sectors: 610/616 (99%) Missing sectors: 0/616 (0%) Bad sectors: 6/616 (0%) writing 77 tracks, 1 heads, 8 sectors, 1024 bytes per sector, 616 kB total
but going to 10 revolutions and 5 retries didn't help. Try 5 retries and 6 revolutions then
tingo@z30b:~/personal/projects/psoc/fluxengine/tmp$ ../fluxengine read ibm -s:d=1:s=0:t=0-76 --retries=5 --revolutions=6 -o 525-nd-f17b-210628f01-xx-01d_5_r6.img [..] H.SS Tracks ---> 0. 0 ............................................................................. 0. 1 ............................................................................. 0. 2 ............................................................................. 0. 3 ............................................................................. 0. 4 .................................................................BB.......... 0. 5 ............................................................................. 0. 6 ......................................................................BBBB... 0. 7 ............................................................................. Good sectors: 610/616 (99%) Missing sectors: 0/616 (0%) Bad sectors: 6/616 (0%) writing 77 tracks, 1 heads, 8 sectors, 1024 bytes per sector, 616 kB total
no improvement.
- 2020-02-04
- another regression test - this time a 5.25 inch, ND format 0b floppy:
tingo@z30b:~/personal/projects/psoc/fluxengine/tmp$ ../fluxengine read ibm -s:d=1:s=0:t=0-76 --retries=0 -o 525-nd-f0b-nd-10005u.img Reading from: :d=1:s=0:t=0-76 Measuring rotational speed... 167ms [..] Autodetecting output geometry H.SS Tracks ---> 0. 0 ............................................................................. 0. 1 ............................................................................. 0. 2 ............................................................................. 0. 3 ............................................................................. 0. 4 ............................................................................. 0. 5 ............................................................................. 0. 6 ............................................................................. 0. 7 ............................................................................. Good sectors: 616/616 (100%) Missing sectors: 0/616 (0%) Bad sectors: 0/616 (0%) writing 77 tracks, 1 heads, 8 sectors, 512 bytes per sector, 308 kB total
Good, checking with 'ndfs', I can both list and extract files from the image.
- 2020-02-04
- doing some regression testing. I've updated FluxEngine (both firmware and client software) to latest from git repository. Trying to read a 5.25 inch, ND format 17b floppy:
tingo@z30b:~/personal/projects/psoc/fluxengine/tmp$ ../fluxengine read ibm -s:d=1:t=0-76 --retries=0 -o 525-nd-f17b-211024-c01-xx-01d.image Error: unrecognised image filename extension
Ok, that's new. Well, let me try it another way then
tingo@z30b:~/personal/projects/psoc/fluxengine/tmp$ ../fluxengine read ibm -s:d=1:t=0-76 --retries=0 -o 525-nd-f17b-211024-c01-xx-01d.img Reading from: :d=1:s=0-1:t=0-76 Measuring rotational speed... 166ms [..] Autodetecting output geometry H.SS Tracks ---> 0. 0 ............................................................................. 0. 1 ............................................................................. 0. 2 ............................................................................. 0. 3 ............................................................................. 0. 4 ............................................................................. 0. 5 ............................................................................. 0. 6 ............................................................................. 0. 7 ............................................................................. 1. 0 ............................................................................. 1. 1 ............................................................................. 1. 2 ............................................................................. 1. 3 ............................................................................. 1. 4 ............................................................................. 1. 5 ............................................................................. 1. 6 ............................................................................. 1. 7 ............................................................................. Good sectors: 1232/1232 (100%) Missing sectors: 0/1232 (0%) Bad sectors: 0/1232 (0%) writing 77 tracks, 2 heads, 8 sectors, 1024 bytes per sector, 1232 kB total
looks good. Using the 'ndfs' tool, I verified that I can list and extract files from the image - it works.
- 2019-07-12
- check the images I captured yesterday against the original images
these images are identical to the original images
tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/210523G02-XX-01D.image test-nd-525-210523g02-xx-01d_r2.image Files ../0_org/210523G02-XX-01D.image and test-nd-525-210523g02-xx-01d_r2.image are identical tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/210523G02-XX-02D.image test-nd-525-210523g02-xx-02d_r2.image Files ../0_org/210523G02-XX-02D.image and test-nd-525-210523g02-xx-02d_r2.image are identical tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/250305M05-XX-01D test-nd-525-250305m05-xx-01d_r2.image Files ../0_org/250305M05-XX-01D and test-nd-525-250305m05-xx-01d_r2.image are identical tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/250305M05-XX-02D test-nd-525-250305m05-xx-02d_r2.image Files ../0_org/250305M05-XX-02D and test-nd-525-250305m05-xx-02d_r2.image are identical tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/250305M05-XX-03D test-nd-525-250305m05-xx-03d_r2.image Files ../0_org/250305M05-XX-03D and test-nd-525-250305m05-xx-03d_r2.image are identical
and these images differ from the original images
tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/10526M07-NO-2D.image test-nd-525-10526m07-no-2d.image Binary files ../0_org/10526M07-NO-2D.image and test-nd-525-10526m07-no-2d.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/10526M07-NO-2D.image test-nd-525-10526m07-no-2d_r2.image Binary files ../0_org/10526M07-NO-2D.image and test-nd-525-10526m07-no-2d_r2.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/10526M07-NO-2D.image test-nd-525-10526m07-no-2d_r4.image Binary files ../0_org/10526M07-NO-2D.image and test-nd-525-10526m07-no-2d_r4.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/10526M07-NO-2D.image test-nd-525-10526m07-no-2d_retries_2.image Binary files ../0_org/10526M07-NO-2D.image and test-nd-525-10526m07-no-2d_retries_2.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/10526M07-NO-2D.image test-nd-525-10526m07-no-2d_retries_2_r2.image Binary files ../0_org/10526M07-NO-2D.image and test-nd-525-10526m07-no-2d_retries_2_r2.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/10526M07-NO-2D.image test-nd-525-10526m07-no-2d_retries_2_r4.image Binary files ../0_org/10526M07-NO-2D.image and test-nd-525-10526m07-no-2d_retries_2_r4.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/210177K01-XX-01D.image test-nd-525-210177k01-xx-01d.image Binary files ../0_org/210177K01-XX-01D.image and test-nd-525-210177k01-xx-01d.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/210177K01-XX-01D.image test-nd-525-210177k01-xx-01d_r2.image Binary files ../0_org/210177K01-XX-01D.image and test-nd-525-210177k01-xx-01d_r2.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/210177K01-XX-01D.image test-nd-525-210177k01-xx-01d_r4.image Binary files ../0_org/210177K01-XX-01D.image and test-nd-525-210177k01-xx-01d_r4.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/210455G02-XX-01D.image test-nd-525-210455g02-xx-01d.image Binary files ../0_org/210455G02-XX-01D.image and test-nd-525-210455g02-xx-01d.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/210455G02-XX-01D.image test-nd-525-210455g02-xx-01d_r2.image Binary files ../0_org/210455G02-XX-01D.image and test-nd-525-210455g02-xx-01d_r2.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/210455G02-XX-01D.image test-nd-525-210455g02-xx-01d_r4.image Binary files ../0_org/210455G02-XX-01D.image and test-nd-525-210455g02-xx-01d_r4.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/210455G02-XX-01D.image test-nd-525-210455g02-xx-01d_r6.image Binary files ../0_org/210455G02-XX-01D.image and test-nd-525-210455g02-xx-01d_r6.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/210523E00-XX-01D.image test-nd-525-210523e00-xx-01d.image Binary files ../0_org/210523E00-XX-01D.image and test-nd-525-210523e00-xx-01d.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/210523E00-XX-01D.image test-nd-525-210523e00-xx-01d_r2.image Binary files ../0_org/210523E00-XX-01D.image and test-nd-525-210523e00-xx-01d_r2.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/210523E00-XX-01D.image test-nd-525-210523e00-xx-01d_r4.image Binary files ../0_org/210523E00-XX-01D.image and test-nd-525-210523e00-xx-01d_r4.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/210523E00-XX-01D.image test-nd-525-210523e00-xx-01d_r6.image Binary files ../0_org/210523E00-XX-01D.image and test-nd-525-210523e00-xx-01d_r6.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/210523E00-XX-01D.image test-nd-525-210523e00-xx-01d_retries_3.image Binary files ../0_org/210523E00-XX-01D.image and test-nd-525-210523e00-xx-01d_retries_3.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/kermit_kom.image test-nd-525-kermit.image Binary files ../0_org/kermit_kom.image and test-nd-525-kermit.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/kermit_kom.image test-nd-525-kermit_r2.image Binary files ../0_org/kermit_kom.image and test-nd-525-kermit_r2.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/ND-10561A.image test-nd-525-nd-10561a.image Binary files ../0_org/ND-10561A.image and test-nd-525-nd-10561a.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/ND-10561A.image test-nd-525-nd-10561a_r2.image Binary files ../0_org/ND-10561A.image and test-nd-525-nd-10561a_r2.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/ND-10561A.image test-nd-525-nd-10561a_r4.image Binary files ../0_org/ND-10561A.image and test-nd-525-nd-10561a_r4.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/ND-10561A.image test-nd-525-nd-10561a_r6.image Binary files ../0_org/ND-10561A.image and test-nd-525-nd-10561a_r6.image differ tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ diff -s ../0_org/ND-10561A.image test-nd-525-nd-10561a_r8.image Binary files ../0_org/ND-10561A.image and test-nd-525-nd-10561a_r8.image differ
A note on image naming. I use the '_rn' suffix on the name to note the revolutions parameters, so '_r2' is --revolutions=2, '_r6' is --revolutions=6 and so on. Torfinn (talk) 14:38, 12 July 2019 (UTC)
- 2019-07-11
- the FluxEngine creator notified me that he had fixed some bugs, and that ND format 17b floppies was reading fine for him now, so I needed to test that as well. I updated the firmware and software to the latest from the Github repository (master branch), set up a 5.25 inch floppy drive and started testing. Torfinn (talk) 14:23, 12 July 2019 (UTC)
- first try
tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ ../fluxengine read ibm -s :t=0-76 --retries=0 -o test-nd-525-210523g02-xx-01d.image [..] H.SS Tracks ---> 0. 0 .....................X...........................................?........... 0. 1 .................................................................X........... 0. 2 ...........................?.....................................X........... 0. 3 .................................................................X........... 0. 4 .................................................................X........... 0. 5 ......?..........................................................X........... 0. 6 .................................................................X........... 0. 7 .................................................................X........... 1. 0 .........?............X.............................?........................ 1. 1 .........X..........................................X........................ 1. 2 .........X..........................................X........................ 1. 3 .........X..............................X...........X........................ 1. 4 .........X..........................................X........................ 1. 5 .........X..........................................X........................ 1. 6 .........X..........................................X........................ 1. 7 .........X..........................................X........................ Good sectors: 1208/1232 (98%) Missing sectors: 24/1232 (1%) Bad sectors: 0/1232 (0%) 77 tracks, 2 heads, 8 sectors, 1024 bytes per sector, 1232 kB total
try with --revolutions=2 to see if it improves the reading
tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ ../fluxengine read ibm -s :t=0-76 --retries=0 --revolutions=2 -o test-nd-525-210523g02-xx-01d_r2.image [..] H.SS Tracks ---> 0. 0 ............................................................................. 0. 1 ............................................................................. 0. 2 ............................................................................. 0. 3 ............................................................................. 0. 4 ............................................................................. 0. 5 ............................................................................. 0. 6 ............................................................................. 0. 7 ............................................................................. 1. 0 ............................................................................. 1. 1 ............................................................................. 1. 2 ............................................................................. 1. 3 ............................................................................. 1. 4 ............................................................................. 1. 5 ............................................................................. 1. 6 ............................................................................. 1. 7 ............................................................................. Good sectors: 1232/1232 (100%) Missing sectors: 0/1232 (0%) Bad sectors: 0/1232 (0%) 77 tracks, 2 heads, 8 sectors, 1024 bytes per sector, 1232 kB total
a clean image. Nice!
tingo@kg-bsbox:~/personal/projects/psoc/fluxengine/tmp$ ~/bin/ndfs -t test-nd-525-250305m05-xx-01d_r2.image Directory name : 250305M05-XX-01D Object file index pointer : 611 SI: 0x1 (indexed) User file index pointer : 613 SI: 0x1 (indexed) Bit file pointer : 615 SI: 0x0 (contiguous) No. of unreserved pages : 1 Files: 0 0: A 20 pages 39497 bytes 1990-01-24 08:12:12 (SYSTEM)MACM-1718L:BPUN 0 1: A 589 pages 1109625 bytes 1990-01-24 08:12:20 (SYSTEM)SINTRAN-M-1:DATA Directory size: 611 pages Bit file size : 1 page
and ndfs can list it (I also tested extracting the files and that works too). I went on read more images, some were ok, and some were not. Torfinn (talk) 14:23, 12 July 2019 (UTC)